Community Documents
I didn't to a deep look at all the functionality. But from my initial assessments this is what I see:
Functionality:
1) You'd lose a point for not initializing all controls and indicators properly at the start of the function
2) Fraction of point for 10 second timeout before card is entered
3) Fraction of a point for not displaying a welcome message after user signs in.
4) All other functionality appears good.
12/15 for functionality or so.
Style:
1) A lot of VIs don't have the controls/indicators at top level (outside all structures)
2) Numerous Disabled Reads in Startup/Shutdown Case that don't do anything
3) Void wires in Shutdown Case
4) Unwired Error out on top vi.
5) Many 1-3 px off wire bends
10-12/15 for style.
Documentation
1) No Icon or Description for Top Level VI
2) No Description for ATM Account Address
3) No Description for Withdraw Money
4) No Icon or Description for Controls
5) Most cases in case structures are not documented
6) Tip strips missing for some controls on top level
6/10 for documentation
Overall I think 28-30/40. 70-75%. Passing
Things to improve on:
Documentation is very easy to get, devote 20-30 minutes at end of test to make sure everything is documented. VI Description, VI Icon, Tip Strips, etc. It shouldn't be hard to get 10/10 here.
Style: VI Analyser is your friend, use it often when practicing to understand where to improve. use it during test to see where major things should be improved with little effort.
Functionality: Pay attention to the Initialize case. It is usually easy to setup and those points carry over into future states.
Thanks Bsvare for that detailed analysis , this was actually my first exam but I am happy you pointed out to some of the flaws, I will be working on them thanks to you
One question though
Style:
1) A lot of VIs don't have the controls/indicators at top level (outside all structures)
what do you mean by outside all structures, do you mean that if subvi has all code in case stucuture that is error or no error cases , i have to put all inputs and outputs outside the structure
3) Void wires in Shutdown Case
what is meant by void wires ?
not needed ? so can i make it use default if unwired?
Functionality:
1) You'd lose a point for not initializing all controls and indicators properly at the start of the function
I didn't understand what you mean by not initializing , i did initalize all controls and indicators , can you guide where exactly please?
In response to style # 1: Yes, even if you use the error in/error out, the other controls and indicators need to be as the same level. It's the difference between these two implementations:
The second one is more efficient for the compiler (doesn't have to make copies of the data depending on what case is selected, or determine what to put for output if the case wasn't chosen) and is simple to create. Just need to make sure there's a default vale for the indicators when going through the error case.
For style # 3. I'm not sure exactly how you did it, but you generated a void wire here:
These can be quickly/easily deleted.
For Functionality #1: In the Exam description it states
"Start (Application Run): When the application starts, the User Input, Enter (E), Left
Menu, Right Menu, Left Buttons, and Right Buttons should be disabled. The Card Simulator button should be enabled and the ATM Messages indicator should display the Welcome Message. Refer to the ATM Message Types section of the specification for message types and font specifications for the messages."
You did not disable the left buttons and right buttons. In fact, I didn't see them ever disabled. So, you can get into weird states where a person can press the withdrawl button before an account is loaded.
